Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMF modeling language fixes #702

Merged
merged 9 commits into from
Sep 29, 2022
Merged

EMF modeling language fixes #702

merged 9 commits into from
Sep 29, 2022

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Sep 29, 2022 •
edited
Loading

Contributes towards #576:

  • Hide the dynamic EMF language, as the other is currently the one to use
  • Shorten the EMF language identifiers
  • Fixes EMF tree views

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Sep 29, 2022
@tsaglam tsaglam added this to the v4.0.0 milestone Sep 29, 2022
@tsaglam tsaglam requested a review from a team September 29, 2022 08:55
@dfuchss
Copy link
Member

dfuchss commented Sep 29, 2022

I would consider just removing the dependency from CLI to emf-dynamic. I'm not sure about hidden languages. Can they be loaded etc. Because the CLI does not know anything about the language option.

@tsaglam tsaglam changed the title Hide dynamic EMF language in the CLI and adapt EMF CLI arguments EMF modeling language fixes Sep 29, 2022
@tsaglam tsaglam marked this pull request as ready for review September 29, 2022 11:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit f41a454 into master Sep 29, 2022
@tsaglam tsaglam deleted the emf-fixes branch September 29, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebinside sebinside sebinside approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
No open projects
v4.0.0 Release
Status: Done
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tsaglam @dfuchss @sebinside